Add DNS server IP address parameter to Invoke-Maester #684
Conversation
To allow the user to pass a custom DNS server IP address down to the underlying CISA Exchange tests, add a cmdlet parameter named DnsServerIpAddress to Invoke-Maester. The default value remains `1.1.1.1`. To enable passing custom data down to the tests, I began using the $PesterConfiguration.Run.Container property. The container will now hold the Path to the tests as well as the custom Data object. The DnsServerIpAddress parameter will be passed to all tests, but the parameter will be silently ignored by any tests without that parameter defined.
|
Thanks for the PR! I am curious if there are pros/cons to passing this value through Pester versus the module itself. |
|
I'm not a Maester or Pester expert (I'm new to both), so don't take my word for it. After digging into how The only way I could see to send parameters to a |
|
The major issue to this approach is that all tests would now share a parameter namespace from |
|
@moorereason thanks for the PR. This goes to the bigger feature around how to pass configuration parameters for various commands and tests (e.g. defining emergency access accounts, accepted number of global admins, etc) We are tracking this in this feature and is something we've been wanting to implement for some time. This way we can use an extensible model to pass config parameters without having to update Invoke-Maester for each test. Just haven't got around to implementing yet. |
|
Closing since this isn't the right direction for the project. I'll look into the PSFramework configurations, if I can find the time. |
To allow the user to pass a custom DNS server IP address down to the underlying CISA Exchange tests, add a cmdlet parameter named DnsServerIpAddress to Invoke-Maester. The default value remains
1.1.1.1.To enable passing custom data down to the tests, I began using the $PesterConfiguration.Run.Container property. The container will now hold the Path to the tests as well as the custom Data object. The DnsServerIpAddress parameter will be passed to all tests, but the parameter will be silently ignored by any tests without that parameter defined.
Updates: #612